Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Builder API schema #2

Merged
merged 38 commits into from
May 10, 2022
Merged

Add Builder API schema #2

merged 38 commits into from
May 10, 2022

Conversation

lightclient
Copy link
Member

This PR adds the schema for the Builder API.

@lightclient lightclient force-pushed the add-api-schema branch 2 times, most recently from 1fe2af9 to 079f909 Compare May 6, 2022 18:27
ralexstokes
ralexstokes reviewed May 6, 2022
View reviewed changes
types/registration.yaml Outdated Show resolved Hide resolved
ralexstokes
ralexstokes reviewed May 6, 2022
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we lost a "status" endpoint?

ralexstokes
ralexstokes reviewed May 6, 2022
View reviewed changes
builder-oapi.yaml Outdated Show resolved Hide resolved
@ralexstokes ralexstokes mentioned this pull request May 6, 2022
Merged
@metachris
Copy link
Contributor

Live version for this spec: https://builderspec-mevboost.metachris.com/#/Builder

metachris
metachris reviewed May 7, 2022
View reviewed changes
apis/builder/header.yaml Outdated Show resolved Hide resolved
lightclient and others added 5 commits May 7, 2022 18:38
@lightclient
add builder bid
50411ce
@lightclient @metachris
adjust get header path and few other fixes
abae993 
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
Co-authored-by: Chris Hager <chris@linuxuser.at>
@lightclient
update oapi
a4ec2dc
@lightclient
use double quotes instead of single quotes
5cfc51e
@lightclient
add more explanation in readme
74c66c1
metachris
metachris reviewed May 7, 2022
View reviewed changes
apis/builder/header.yaml Outdated Show resolved Hide resolved
tersec
tersec reviewed May 9, 2022
View reviewed changes
specs/README.md Outdated Show resolved Hide resolved
metachris
metachris reviewed May 9, 2022
View reviewed changes
specs/README.md Outdated Show resolved Hide resolved
ralexstokes
ralexstokes reviewed May 9, 2022
View reviewed changes
specs/README.md Outdated Show resolved Hide resolved
ralexstokes
ralexstokes reviewed May 9, 2022
View reviewed changes
specs/README.md Outdated Show resolved Hide resolved
ralexstokes
ralexstokes reviewed May 9, 2022
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few minor things to address but starting to look really good!!

@lightclient @ralexstokes
apply pr feedback
40a8e67 
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
djrtwo
djrtwo reviewed May 10, 2022
View reviewed changes
Copy link
Collaborator

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! did a pass. looking good

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
apis/builder/header.yaml Outdated Show resolved Hide resolved
apis/builder/header.yaml Outdated Show resolved Hide resolved
apis/builder/status.yaml Show resolved Hide resolved
apis/builder/validators.yaml Outdated Show resolved Hide resolved
apis/builder/validators.yaml Outdated Show resolved Hide resolved
apis/builder/validators.yaml Outdated Show resolved Hide resolved
specs/README.md Outdated Show resolved Hide resolved
types/registration.yaml Show resolved Hide resolved
lightclient and others added 3 commits May 10, 2022 23:14
@lightclient @djrtwo
add feedback from review
6513551 
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
@lightclient
accept only single validator registrations
565d1db
@lightclient
add spellcheck to ci
85b0c48
@lightclient
Copy link
Member Author

I really appreciate everyone's feedback. I'm going to go ahead and merge this as the feedback has slowed and things seems to be in a pretty solid place.

@lightclient lightclient merged commit 620ddd9 into ethereum:main May 10, 2022
@metachris metachris mentioned this pull request May 11, 2022
Merged
This was referenced May 18, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metachris metachris metachris left review comments

@djrtwo djrtwo djrtwo left review comments

@ralexstokes ralexstokes ralexstokes left review comments

@rootulp rootulp rootulp left review comments

@tersec tersec tersec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lightclient @metachris @djrtwo @ralexstokes @rootulp @tersec